accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Single designs

Open akashagrjsr opened this issue 5 years ago • 10 comments

  • [x] Screenshots are incorrect

  • [x] There needs to be a name and a preview link

  • [x] Need to create a third new design for single (https://monosnap.com/file/K6kYLaZtiXr3ED5RBm8xrPzZuRKnVx)

  • [x] Crafting of New single design

  • [x] Proper screen shot need to add in the Option panel > Design > Single 3

akashagrjsr avatar May 04 '19 07:05 akashagrjsr

Back end Tasks

  • [x] Sidebar option need to change according to the Design selector please see the screenshots 1).https://monosnap.com/file/47Bm097wtSyDhxYYMzEOp7CgmbTBC6 2).https://monosnap.com/file/YtquSm91hKI6vs6u2iqKaR857g5LDj

  • [x] When excerpt option is enabled and if excerpt content is not added, the the problem is coming like this. see the screenshot https://monosnap.com/file/YbKPgi4pvv7hjif8BMIWxVQWDEm58g more info: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/3511

Front end Tasks

  • [x] Recent Post Label name in option panel

  • [x] sidebar color options need to take out side of homepage sidebar switch https://monosnap.com/file/rlYDxjvuY6rayLSHUmoVbDP0hPX2Dt

  • [x] Sidebar color options need to connect for single design 7.

raju-jeelaga avatar Jul 04 '19 13:07 raju-jeelaga

In a single design's 3, getting validation error: https://take.ms/0t2at

pegazee avatar Jul 29 '19 06:07 pegazee

When this ticket is ready to merge in master, need to add this ticket also #3500

raju-jeelaga avatar Jul 30 '19 13:07 raju-jeelaga

When the sidebar is disabled signal design 3 automatically jumping to signal design1 in swift

sonaliramteke avatar Aug 05 '19 10:08 sonaliramteke

If I disable the main sidebar then also design 2 is getting selected https://prnt.sc/owhlp6 https://prnt.sc/owhlui

And also if anyone selected design 3 then it should not go to design 2 and if anyone using design one then only it should go to design 2 and not design 3 because both 2 and 3 has the sidebar in single. https://prnt.sc/owhn9a https://prnt.sc/owhnel

Zabi09 avatar Aug 23 '19 10:08 Zabi09

This ticket https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/3576 will be resolved on this ticket.

https://secure.helpscout.net/conversation/932256832/78631?folderId=2632030

ghost avatar Aug 27 '19 11:08 ghost

  • [x] Button should select the design. https://take.ms/Nyu2u

  • [x] Escaping missing https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/cbb48c863581f4e10bc577865bdd52d342c2f98f#diff-eb310122bd207e608372e60fa377d5d8R194

  • [x] Social icons code needs improvement https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/4cdc74b41c37053a0494746e2d93fdb18da0e696#diff-7d3a92ac5e6165548bf9bc556f4f887aR573

  • [x] Are you sure the image dimension is 200X150 ? https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/e27c300c1fef1323d4019bc15274edc76bd62ff1#diff-7d3a92ac5e6165548bf9bc556f4f887aR707

  • [x] Escaping missing https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/5dc8afcba0c6f5b4be8309a6f5c5f235c9fe3454#diff-2ae5550e31f40c1962ca69d373af6b93R2588

  • [x] Post pagination in mobile screens is not good.

MohammedKaludi avatar Oct 12 '19 14:10 MohammedKaludi

Why removed this code? <?php ampforwp_nofollow_social_links(); ?>

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/cc556a629a66b1b8214f85c826a958663df499de#diff-9bf04cd42bc2066da77791b1697c5481R107

MohammedKaludi avatar Oct 24 '19 14:10 MohammedKaludi

Twitter code improvement is required in d1,d2 and d3.

MohammedKaludi avatar Oct 25 '19 11:10 MohammedKaludi

  1. When AMP pagebuilder is active unwanted elements are visible.
  2. Related posts at the end not looking good.

MohammedKaludi avatar Oct 25 '19 14:10 MohammedKaludi