accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Need to add Social Icon module in pagebuilder

Open pegazee opened this issue 6 years ago • 6 comments

The social sharing buttons only appear in pages when edited by “custom AMP editor” but not by “AMP page builder”. We need to add a social icon module for this scenario.

ref: https://wordpress.org/support/topic/social-share-button-2/

pegazee avatar Jan 14 '19 10:01 pegazee

There is another user is asking.

REF:https://secure.helpscout.net/conversation/889281410/71927?folderId=3008055

SayyadF avatar Jul 08 '19 11:07 SayyadF

Notice: Undefined variable: amp_permalink in C:\xampp2\htdocs\wp\wp-content\plugins\accelerated-mobile-pages\pagebuilder\modules\social-share-module.php on line 31 and also please change the function name

Zabi09 avatar Nov 04 '19 12:11 Zabi09

Call to undefined function ampforwp_sanitize_twitter_title - in plugins\accelerated-mobile-pages\pagebuilder\modules\social-share-module.php:25

Zabi09 avatar Dec 26 '19 09:12 Zabi09

UI improvement required in the backend: https://take.ms/bysyj

Output not looking good as well: https://take.ms/xj2UU

Function name is not correct. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/afddd954a2cc9e8dde8fd1f3b282eaf8fde41b73#diff-0d00031844fc2daf2d2f57963ec5003fR5

MohammedKaludi avatar Jan 04 '20 15:01 MohammedKaludi

UI improvement required in the backend: ------------------ After Discussion with @ahmedkaludi, he told me that checkbox option is fine and remove the yes Label.

Output not looking good as well: --------------underline is removed and Facebook like button styling problem will be fixed in this ticket #4043

Function name is not correct: ------------- Function name properly added.

raju-jeelaga avatar Jan 06 '20 09:01 raju-jeelaga

ready to merge.

MohammedKaludi avatar Jan 08 '20 12:01 MohammedKaludi