accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Published 20 hours ago • verified publisher icon ahmedkaludi

Need to create an option for Dark Mode.

Open Rkroy opened this issue 6 years ago • 11 comments

Need to create an option for Dark Mode. Ref : https://secure.helpscout.net/conversation/744607898/48084?folderId=2322652

Rkroy avatar Jan 07 '19 12:01 Rkroy

@ahmedkaludi As per our Discussion, I added the Dark Mode option only for the Swift in condition, In future we will implement this option for all Designs 1,2 and 3...

raju-jeelaga avatar Mar 04 '19 10:03 raju-jeelaga

The button in the frontend - https://prnt.sc/mte1n2 is not connected with the AMP panel option - https://prnt.sc/mte1qj

Zabi09 avatar Mar 05 '19 07:03 Zabi09

Little bit of crafting work is pending, Need to work with @ahmedkaludi https://monosnap.com/file/2wplf9NsrGnyI9xeZ0M5q1dgp9163O

raju-jeelaga avatar Mar 06 '19 09:03 raju-jeelaga

I think we need to give the tooltip for the dark mode option. screenshot: https://take.ms/mxKLV

Discuss this with @ahmedkaludi

pegazee avatar Apr 30 '19 06:04 pegazee

  • [x] Widgets are not connected with dark mode. https://take.ms/nBvGy

  • [x] When changing the switch of Dark mode, the page reloads and it is taking to the homepage. It should reload on the same page. Steps to Recreate: Change the Darkmode switch in the single.

MohammedKaludi avatar Aug 28 '19 09:08 MohammedKaludi

Use wp_get_referer instead of $_SERVER['HTTP_REFERER']

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/9097709059a1a493e4a90ecf06dc849220eaf044#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7530

https://codex.wordpress.org/Function_Reference/wp_get_referer

MohammedKaludi avatar Aug 28 '19 14:08 MohammedKaludi

  1. Do not use $_SERVER use alternative WordPress method.
  2. Escaping missing on lot of places.
  3. Conditioning needs to be improved.

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/a3149d82c625e9ee266fc25de41bce0480d8a741#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7098

MohammedKaludi avatar Aug 30 '19 14:08 MohammedKaludi

After Discussion with @MohammedKaludi sir, The above 3 things need to fix, when it is merging in to master

raju-jeelaga avatar Sep 07 '19 09:09 raju-jeelaga

add priority of 12 while merging. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/a3149d82c625e9ee266fc25de41bce0480d8a741#diff-6aa5512f7dd8d5ce60fc97b0f340912cR7088

MohammedKaludi avatar Oct 09 '19 12:10 MohammedKaludi

One user also requesting the same feature ( Dark Mode ) at high priority - https://secure.helpscout.net/conversation/1794200841/227991?folderId=4459751

kupveja avatar Mar 04 '22 11:03 kupveja

A user is requesting for the same feature: https://magazine3.in/conversation/218651?folder_id=27

sajandara avatar Nov 29 '23 13:11 sajandara