Hide AMP Bulk tools for Custom Post Types

[mdkaleem95]

Need to create a custom post type option in Individual AMP Page (Bulk Edit). so a user can hide or show the custom post type.

For more details please visit the help scout link:

Ref: https://secure.helpscout.net/conversation/628376164/30967?folderId=1914712

[MohammedKaludi]

Can we use has_category in this as well and optimize the code?

[ajeetku]

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/90c9dde0187decdd6e2d0371e82e912be8ad60ec#diff-6aa5512f7dd8d5ce60fc97b0f340912cR2905 here need page ID but passed wrong id (recent post id from global value)

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/90c9dde0187decdd6e2d0371e82e912be8ad60ec#diff-6aa5512f7dd8d5ce60fc97b0f340912cR2907 why get_the_ID() used if we need to update on all pages

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/90c9dde0187decdd6e2d0371e82e912be8ad60ec#diff-6aa5512f7dd8d5ce60fc97b0f340912cR2912 here $post->post_type why taken from global $post, we are already getting current post_type from loop

[pegazee]

** Review **

• [x] Kaleem

• [x] Imran

[MohammedKaludi]

Labeling improvements required. https://take.ms/Pmpuz

Use the same method mentioned in #2301

Also consult with me once as you start the work on it

[MohammedKaludi]

Escaping required and Some Types are not visible https://take.ms/SmhA9

[MohammedKaludi]

esc_attr should be used instead of esc_html

https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/0fd9dec02ea7418ecd0ea5870d7d4c14ba3f951e#diff-6aa5512f7dd8d5ce60fc97b0f340912cR3259

[MohammedKaludi]

esc_attr should be used instead of esc_html

Still missing on other places.

[MohammedKaludi]

Ready to merge, need to update the label and make sure the Defaults are changing for post type after the merge.