accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard
verified publisher icon ahmedkaludi

New Desing Slider Gallery Images.

Open mdkaleem95 opened this issue 7 years ago • 12 comments

Ref: https://secure.helpscout.net/conversation/592350115/27246?folderId=1914712

mdkaleem95 avatar Jun 09 '18 09:06 mdkaleem95

https://www.swipty.dk

merajali294 avatar Jun 22 '18 12:06 merajali294

Pending Issues

  • [x] Slider design 3 Dots Functionality not working properly [Ajeet]

  • [x] Slider Desing 4 Required Filed is not working [Ajeet].

  • [x] Crafting is pending for Slider Mod Design 3 and 4 [ Raju, Ahmed]

  • [x] Screenshots of Desing3 and Desing 4.[Raju]

raju-jeelaga avatar Jun 29 '18 05:06 raju-jeelaga

  • [x] Slider Design 4 Html and css added and Fields are created and connected to option and pgb 016648b

raju-jeelaga avatar Jun 29 '18 13:06 raju-jeelaga

REVIEW:

  • [x] Change the order "Layout" to second position: http://take.ms/DaWnO

ahmedkaludi avatar Aug 10 '18 07:08 ahmedkaludi

Let's change the name as per our discussion. Gallery will be "Logo" Slider will be "Gallery / Slider"

ahmedkaludi avatar Aug 17 '18 12:08 ahmedkaludi

REVIEW

  • [x] Let's order the module names correctly: http://take.ms/3zYcc

ahmedkaludi avatar Aug 18 '18 07:08 ahmedkaludi

Review

  • [x] Arrow doesn't look good: http://take.ms/DhB1L - From D1 - D3, Use the arrow we have in the menu http://take.ms/Szk2q - and for the D4, we have the icon font.

ahmedkaludi avatar Sep 11 '18 11:09 ahmedkaludi

Make sure to add Convert AMP to WP code from https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/2771 while merging this ticket.

MARQAS avatar Jul 19 '19 14:07 MARQAS

It is issue with @media query merger ampforwp_pb_autoCompileLess this functions preg_replace creating some issue to combine @media queries for now i change the @media screen size 768px to 769px after fix this issue #3797 need to add the proper screen size.

raju-jeelaga avatar Oct 24 '19 10:10 raju-jeelaga

  • [x] font awesome [Custon code with CSS is added for angle bracket ]

  • [x] responsive of the First new slider (http://localhost/ampforwp/wp-content/plugins/accelerated-mobile-pages//images/slider-3.png)

  • [x] D2 of slider, if img is not present, then validation error

  • [x] box shadow for d2 slider

  • [x] d2 slider looks strange background color in Design one

raju-jeelaga avatar Oct 25 '19 09:10 raju-jeelaga

Slider Design 1 Responsive is not looking good because of Media queries are removing automatically when merging. Note: We need to push the current ticket based on this #3797 [This ticket will fix the media query problem]

raju-jeelaga avatar Oct 25 '19 14:10 raju-jeelaga

Note: For Now Testing purpose i change the media screen sizes and push the code, once this #3797 ticket is fix, then need to add the proper media screen sizes.

raju-jeelaga avatar Oct 28 '19 06:10 raju-jeelaga