accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Order of elements on the page

Open ahmedkaludi opened this issue 7 years ago • 23 comments

Is it possible to reorder the elements on the page?

For example, the current order at the end of a post (1) there is the author box (2) and then Facebook comments (3):

[email protected]

Can I reorder this to show the end of the post (1), followed by the Facebook comments (3), and then the author box (2). A mockup something like this:

[email protected]

Thank you for the help. More questions to come, but I don't want to send so many at one time.

REF: https://secure.helpscout.net/conversation/564937851/24821?folderId=673452

ahmedkaludi avatar Apr 23 '18 08:04 ahmedkaludi

Please consult with @ahmedkaludi if you having any query

mdkaleem95 avatar Jul 23 '18 11:07 mdkaleem95

Ref: https://secure.helpscout.net/conversation/623947568/30583?folderId=1914712

mdkaleem95 avatar Jul 23 '18 11:07 mdkaleem95

Review

  • [x] If a user is using old Layout manager (http://take.ms/yYA6e) then those settings will be applied to him by default ( http://take.ms/yYA6e ), so we can migrate the users from old to the new option ( http://take.ms/YFHAU ) without any changes in their sites.

  • [x] It should work with All the designs. (we can have diff fields for diff singles.)

ahmedkaludi avatar Aug 18 '18 06:08 ahmedkaludi

It is already taking its default value from Old layout manager. And it is working with all three designs except Swift.

MARQAS avatar Aug 24 '18 07:08 MARQAS

Reviewed.

ahmedkaludi avatar Aug 24 '18 09:08 ahmedkaludi

REVIEW:

  • [ ] We need to implement in Design 4

ahmedkaludi avatar Sep 20 '18 09:09 ahmedkaludi

How can we implement it in Design4? Design 4 is not built upon on that base, rather it is built on the base of ATF. And I don't think we can control it with this option at the moment, if there's a way then please let me know.

MARQAS avatar Sep 26 '18 05:09 MARQAS

The new layout manager for AMP theme framework based themes like Swift http://take.ms/STVfT

wireframepro - fgfgf _ page 1 - google chrome 2019-01-02 15 46 18

MohammedKaludi avatar Jan 02 '19 10:01 MohammedKaludi

** Review **

  • [x] Kaleem

  • [ ] Imran

pegazee avatar Mar 11 '19 10:03 pegazee

@ajeetku Components Layout Manager option is rendering in amp theme framework check it once are we implementing it or not in amp theme framework?

syedimran22 avatar Mar 25 '19 12:03 syedimran22

When merging this ticket in master make sure that to add this code ( ticket: #2416 ) also https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/f4c622766373f5ffc54af78d4547fb9108696d9d

pegazee avatar Apr 25 '19 14:04 pegazee

Please let me know if there are any problems in pushing, we can discuss offline rapidly

ahmedkaludi avatar May 01 '19 15:05 ahmedkaludi

Please let me know if there are any problems in pushing, we can discuss offline rapidly

ok

MohammedKaludi avatar May 01 '19 15:05 MohammedKaludi

NO option found to handle the feature.

MohammedKaludi avatar May 01 '19 15:05 MohammedKaludi

Facebook comments are not connected with the options panel. https://take.ms/tdmpz

MohammedKaludi avatar Oct 12 '19 14:10 MohammedKaludi

Ready to merge.

MohammedKaludi avatar Oct 17 '19 11:10 MohammedKaludi

Hope There is a new update about "Regarding the changing the order of elements like comment form below the article, and above the section."

ruaconx11 avatar Feb 11 '20 02:02 ruaconx11

Hey @ruaconx11 it is now planned for next update.

MohammedKaludi avatar Mar 06 '20 11:03 MohammedKaludi

Issues found during testing.

  • [ ] if we change the order of category and tag then the author bio section also changing the position. (I think there should be a separate option for author bio)

  • [x] ad7 and ad8 options are not working.

ansaritalha avatar Mar 09 '20 05:03 ansaritalha

  • [x] If the option is disabled then it should be in disabled by default - https://prnt.sc/rdlce4

  • [x] Need to add Adsense and also MGID in both Ad 7 and 8 - https://prnt.sc/rdm2dk

Zabi09 avatar Mar 09 '20 06:03 Zabi09

  1. When we disable breadcrumbs and click on the save button then its showing enabled same in related posts also -> https://prnt.sc/rlnyhr
  2. Category and Tags option is connected to Author Bio option
  3. MGID Ads is not working Ads7 and Ads8

sonaliramteke avatar Mar 24 '20 07:03 sonaliramteke

element_layout_customizer() need to improve the function name

MohammedKaludi avatar Mar 27 '20 23:03 MohammedKaludi

Add this social icons are outside of container in design 3 https://monosnap.com/file/cPxvymiIVab0QFgdmgyYNk4nDhH0fR

MohammedKaludi avatar Mar 27 '20 23:03 MohammedKaludi