action-dependabot-auto-merge icon indicating copy to clipboard operation
action-dependabot-auto-merge copied to clipboard

Published 20 hours ago • verified publisher icon ahmadnassri

Fix version detection

Open eliashaeussler opened this issue 2 years ago • 2 comments

The current version detection fails since it's not strict enough. For example, given the PR title

Bump @fontsource/lato from 4.5.5 to 4.5.8

Both from and to versions are parsed as 4.5.5, because the word to is included in the dependency name as well. A real world example can be seen at https://github.com/eliashaeussler/typo3-badges/runs/6348654008?check_suite_focus=true.

Solution: The corresponding regexes have been adapted to enforce a whitespace prior to the from and to terms.

Fixes #114.

eliashaeussler avatar May 09 '22 09:05 eliashaeussler

Hi @ahmadnassri, is there any chance to get this merged soon?

eliashaeussler avatar Oct 05 '22 08:10 eliashaeussler

I'm also facing a similar issue with @fontsource/roboto updates. I've spent some time debugging the action before I stumbled upon this PR which fixes the regex pattern.

@ahmadnassri sorry for pinging you again, but is there any chance this could be merged and released? If you think that more work is needed in the form of unit tests, just let me know, I'm happy to contribute!

lpgera avatar Aug 06 '23 08:08 lpgera