iran-cities icon indicating copy to clipboard operation
iran-cities copied to clipboard

What is `diag` in `abadi` table? Some attribute naming issues.

Open SaliBhdr opened this issue 3 years ago • 2 comments

Hi,

I do not understand some of the attributes namings. For example 'diag' in abadi table, abadi_type in abadi table, shar_type in shahr table. the type 0 or 1 is not understandable. I suggest that you use enums instead of just 0 or 1 and add comments to some of these fields for better understanding.

ps: Please clarify these fields if you can.

Thank you

SaliBhdr avatar Jul 05 '21 06:07 SaliBhdr

Hello Salar,

abadi type 0 means a typical village. type 1 means an industrial zone, a small group of buildings, facilities, factories and so on.

Large cities have discrete divisions called distinct. shahr type 0 refers to a whole city but type 1 refers to a record indicating a city distinct. like Tehran distinct 1, 2, and so on.

You can ignore the diag field. right now it doesn't have any specific usage and for your information it's a combination of different identifiers describing a zone.

Enum type is not treated the same way on different DBMSs and for compatibility we prefer to use the integer type(In some DBs like MySQL enum types are actually stores as small integers)

ahmadazizi avatar Jul 09 '21 16:07 ahmadazizi

@ahmadazizi

Thank you for the response.

Could you please describe the diag's identifiers? As long as I can see it's just a number.

Could you explain the structure of the diag?

Thanks in advance!

SaliBhdr avatar Jul 13 '21 07:07 SaliBhdr