shades-of-purple-vscode icon indicating copy to clipboard operation
shades-of-purple-vscode copied to clipboard

📦 NEW: SOP Italics Version

Open Oluwasetemi opened this issue 6 years ago • 8 comments

I thought we could extend this to all type of fonts giving them the feel of italics by creating a scope for things like comments, keywords and setting the fontStyle to italic.

This will make italic available to any font used with SOP

Oluwasetemi avatar Jul 24 '18 13:07 Oluwasetemi

@Oluwasetemi welcome here. Can you mention which entities do NOT render as italic that are intended in the theme to be italic and are so with Operator Mono? Coz. anything that's meant to be italic is set to do so in the syntax settings.

Give an example or two so that I can investigate.

ahmadawais avatar Jul 24 '18 14:07 ahmadawais

italics

Here is my own italics I tried the default theme on my friend's system then i saw it didn't have some italics but I think Operator mono come with some italics default!

Oluwasetemi avatar Jul 29 '18 21:07 Oluwasetemi

Looking through this repo i am learning a lot especially with generating the CHANGELOG.md automatically using clTemplate.hbs is so cool.

Oluwasetemi avatar Jul 29 '18 21:07 Oluwasetemi

@Oluwasetemi glad you're learning from my work. Looking into the italics.

ahmadawais avatar Aug 16 '18 12:08 ahmadawais

@Oluwasetemi Can you send me the italics data above in the screenshot as text. I can't create it again. Easier to copy paste.

Here're the italics that are already in there in 🦄 Shades of Purple:

{
			"name": "[ITALLICS] All the awesome itallics live here.",
			"scope": [
				"modifier",
				"this",
				"comment",
				"storage.modifier.js",
				"entity.other.attribute-name.js",
				"entity.other.attribute-name.html",
				"punctuation.definition.comment",
				"text.html.basic entity.other",
				"entity.other.attribute-name.tsx",
				"entity.other.attribute-name.jsx",
				"markup.quote.markdown meta.paragraph.markdown",
				"markup.italic.markdown",
				"text.jade entity.other.attribute-name.tag",
				"keyword.control.from.js",
				"entity.other.attribute-name.tag.pug"
			],
			"settings": {
				"fontStyle": "italic"
			}
		}

ahmadawais avatar Aug 16 '18 12:08 ahmadawais

 {
  "scope": [
    "comment",
    "keyword.control",
    "keyword.operator.new",
    "keyword.operator.assignment",
    "keyword.operator.arithmetic",
    "keyword.other",
    "storage.modifier",
    "storage.type",
    "support.class",
    "support.constant",
    "support.function",
    "support.other",
    "entity.name.class",
    "entity.name.function",
    "entity.name.method",
    "entity.name.section",
    "entity.name.selector",
    "entity.name.type",
    "entity.other",
    "entity.other.attribute-name",
    "entity.other.inherited-class"
  ],
  "settings": {
    "fontStyle": "italic"
  }
}

Oluwasetemi avatar Aug 19 '18 06:08 Oluwasetemi

Just wondering about this, is it meant to be a variation of SOP that places more of an emphasis on increased syntax italicisation? If so, I'm all aboard the idea!

Coming from Palenight, it has in-built a dedicated variation of the theme which extends support for Operator Mono. Thereby, more code is italicised than is usually expected from a theme, hence it is an option that the user can choose to enable.

As usual, a picture speaks a thousand words, so you can see below the following scope is italicised: HTML tag property values, CSS selector names, JS var/return/if/for/function and the likes.

image

rdhar avatar May 03 '19 21:05 rdhar

@rdhar Oh yes, I haven't had a chance to work on the italic version in the last 8 months but there are already some experiments here.

Ultimately I want five versions of 🦄 Shades of Purple

  • 🦄 Shades of Purple Default
  • 🦄 Shades of Purple Dull/Dimm/Mutted
  • 🦄 Shades of Purple High Contrast
  • 🦄 Shades of Purple Light
  • 🦄 Shades of Purple Italic

For all that we need to build tooling like webpack would compile all these themes from one source automagically. That's a lot of work but you can help.

ahmadawais avatar May 03 '19 21:05 ahmadawais