corona-cli icon indicating copy to clipboard operation
corona-cli copied to clipboard

Display data for specific countries in one command

Open djuric opened this issue 5 years ago • 9 comments

First of all thank you for this project, it's very useful and easy to use :)

I think this addition would be really nice, it's a way to display data for specific countries separated by '-'. For example:

corona italy-spain

or

corona us-uk-italy-spain

This way we can compare data from selected countries in the same table.

djuric avatar Mar 22 '20 14:03 djuric

Glad you like my work. This is a fantastic idea. Something I have been thinking about.

Some countries have - in their names. So maybe we should use a different separator. Let's say _? Thoughts?

ahmadawais avatar Mar 22 '20 18:03 ahmadawais

This fixes #15.

ahmadawais avatar Mar 22 '20 18:03 ahmadawais

@ahmadawais you are right, it looks like there can be a country with - in the name. And & (which would be nice) will not work either because it's recognized as next command.

So yes, _ is a good candidate. I was also thinking about / but this looks a bit odd, it implies it's a directory path :)

djuric avatar Mar 22 '20 20:03 djuric

Thanks for the PR. Can you please update the PR in light of the latest release.

🔗 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0 🔗 https://www.npmjs.com/package/corona-cli

ahmadawais avatar Mar 24 '20 19:03 ahmadawais

@ahmadawais you are right, it looks like there can be a country with - in the name. And & (which would be nice) will not work either because it's recognized as next command.

So yes, _ is a good candidate. I was also thinking about / but this looks a bit odd, it implies it's a directory path :)

What about comma? Like: usa,italy,spain

fayaz-dev avatar Mar 29 '20 21:03 fayaz-dev

Aha , would be perfect!

ahmadawais avatar Mar 30 '20 00:03 ahmadawais

Can you update this PR with , as the separator and use the new route where you can just define a list of countries?

https://corona.lmao.ninja/countries/us,italy,spain

ahmadawais avatar Apr 06 '20 01:04 ahmadawais

@ahmadawais , added as a separator. It looks and works better then other symbols, thanks @fayazmiraz :)

djuric avatar Apr 14 '20 00:04 djuric

@ahmadawais , added as a separator. It looks and works better then other symbols, thanks @fayazmiraz :)

Great, thank you :)

fayaz-dev avatar Apr 14 '20 02:04 fayaz-dev