CICFlowMeter icon indicating copy to clipboard operation
CICFlowMeter copied to clipboard

Purpose of forward check in BasicPacketInfo. generateFlowId()?

Open lisa-lthorrold opened this issue 2 years ago • 0 comments

I can't understand what the purpose of this check is, or in actual fact what is actually being checked. How is the direction determined based solely on ips without context/history, or is the variable name misleading. It results in flowids which are inconsistent with actual src and dest ips features and the calculated features in BasicFlow.java which handles directionality.

Or perhaps, could you clarify if or what semantic directionality intended is for a flowid, or whether the function is to ensure the flowids are generated in a consistent manner (in which case the variable name forward is quite misleading)

I haven't vetted thoroughly but this could impact methods that determine flow existence/directionality based on the flowids

lisa-lthorrold avatar Jun 24 '22 04:06 lisa-lthorrold