Bulk calculations incorrect

[lisa-lthorrold]

	public void updateFlowBulk (BasicPacketInfo packet){

		if(this.src == packet.getSrc()){
			updateForwardBulk(packet,blastBulkTS);
		}else {
			updateBackwardBulk(packet,flastBulkTS);
		}

	}

The src/dest values are byte arrays. This is a memory address comparison that will always return false, so everything is added to the backward bulk summary statistics. The correct comparison method should be if (Arrays.equals(this.src, packet.getSrc()))

This has implications for 6 features:

• Fwd Avg Bytes
• Fwd Avg Packets
• Fwd Avg Bulk Rate
• Bwd Avg Bytes
• Bwd Avg Packets
• Bwd Avg Bulk Rate

And the datasets generated before this is fixed will not have the correct values as the author intended, I suspect

[zyzshishui]

I'm implementing this project to c++ and I just found the same issue with you. I also noticed that the 6 features you listed have been set to 0 in the released cicids2017.