Alex Henning Johannessen

Results 108 comments of Alex Henning Johannessen

I do not have the bandwidth to review currently, unfortunately :/ I can take a look when I find the time.

@TalkingFoxMid Can you remove the companion object of `Fs2GrpcServicePrinter` as the constants are now in the abstract printer's companion. Edit: Nevermind, I'll merge and remove it.

Did a [v2.7.15](https://github.com/typelevel/fs2-grpc/releases/tag/v2.7.15) release - Should be on sonatype soon.

I had to revert your PR that I merged as the changes are breaking the build of downstream projects. I need to look into it.

@ValdemarGr I think this looks promising. Should `mkClientFull` and `mkServiceFull` be on `GeneratedCompanion` and trivial implemented in `GeneratedCompanion` in terms of that?

> From my observation, users usually parse the protobuf structures into more idiomatic scala datatypes so maybe the Dom and Cod typeclass usecase is not of that much value? In...

> Yes let's move forward with this. > I'll make sure the tests are green and construct tests that use the new features to implement tracing and auth. Sound like...

@ValdemarGr Perhaps getting more eyes from typelevel on the PR would be a good idea?

@rossabaker @armanbilge @fiadliel What do you guys think about this change? :)

Yep, I think grpc-java behaves similarily?