Andrew Hayworth

Results 117 comments of Andrew Hayworth

Tests should pass after #1236 is merged.

> Did you update the rake file for updating the protos? https://github.com/open-telemetry/opentelemetry-ruby/blob/main/exporter/otlp/Rakefile#L32-L37 Oh - I did it manually by 1) cloning the proto repo and switching to the tag, 2)...

That is a far more full-featured test than I was expecting, thank you @robbkidd !

@fbogsany I merged `main` and the conflict went away ... which seems mysterious but I do think the git client has gotten smarter about stuff these days. 🤷

@sodabrew we could cut one - I will ask in the [CNCF slack](https://slack.cncf.io) (`#otel-ruby`, if you wish to join).

@johnnyshields I actually don't think the configurator block supports this yet - I believe the best way to do it globally is via environment variables. See the test suite here...

I added schema url support in #1237, although I didn't bother adding it to any instrumentation. > It's unclear what the next steps are for this feature, I think they're...

Yeah - that may very well be the case. But I definitely think it's worth a little bit of time exploring. Synchronization _now_ will probably be easier than down the...

The constructor for a `Link` doesn't accept named parameters: https://github.com/open-telemetry/opentelemetry-ruby/blob/ad51972e9bdc8ead0e69642056a4935683464dfc/api/lib/opentelemetry/trace/link.rb#L35 If you inspect the `link` object you are creating directly, you can see that we get something unexpected: ``` opentelemetry-ruby/sdk...

@ivoanjo We talked about this today in the Ruby SIG - we'd like to continue to push back since we think this is largely only safe in MRI and we...