docker-thrift icon indicating copy to clipboard operation
docker-thrift copied to clipboard

Add support for ARMv8 platform

Open khasim opened this issue 6 years ago • 7 comments

The following changes are done to get Thrift working on docker containers running on ARMv8,

a) The wheezy base package doesn't work for arm64, hence moving to latest debian "stretch" package. b) Download the golang package based on the architecture as they are different for arm64 and amd64

khasim avatar Sep 06 '18 15:09 khasim

This PR LGTM.

Is there any chance we can have it merged please?

lag-linaro avatar Nov 15 '18 10:11 lag-linaro

Is this project still maintained? If not, perhaps it should be deprecated.

lag-linaro avatar Dec 13 '18 13:12 lag-linaro

This project is not intended to provide a runtime environment for thrift. It provides the thrift compiler which is a code generator written in C++, and makes it easier for folks using other languages to compile thrift files. I would recommend closing this.

jeking3 avatar Feb 06 '19 20:02 jeking3

Actually @jeking3 this project is intended to provide a runtime environment for people to run Thrift. When you say "this project", I think you are referring to the parent project, https://github.com/apache/thrift, which you help maintain, right?

If this project is still maintained, it should be extended to support other architectures.

lag-linaro avatar Feb 07 '19 06:02 lag-linaro

I do not see how this project provides a runtime environment for people to run thrift projects. It provides the compiler, which is useful when you are using a language like NodeJS and need a way to compile thrift without building it. This container has some preliminary support for golang and that's it. No ruby, python. dotnet, nodejs, swift, as3, ... in here. That's what I base my assumption on, that this project provides a thrift compiler, which is a useful thing to provide. If you want a container that supports all 28 languages thrift supports including the runtime libraries for those languages, you would want to use the container the apache/thrift project uses to build thrift in CI.

Perhaps people use this as a base docker image and then layer a runtime environment on top of it for the language(s) they are using, in their own Dockerfile? Is that how this is used? That would also make sense. But again, in that case, this is just providing the compiler.

jeking3 avatar Feb 07 '19 19:02 jeking3

To be honest, I have no idea how this project is consumed.

All I can say is that many people (1M+) are consuming it, so it must be of use to someone.

If people are consuming it, we would like provide the possibility for it to be used on an AArch64 platforms.

lag-linaro avatar Feb 19 '19 12:02 lag-linaro

@ahawkins any chance of updating the now out-of-date wheezy base to stretch?

lag-linaro avatar Feb 19 '19 12:02 lag-linaro