docker-thrift
docker-thrift copied to clipboard
Support thrift for ARM64
Hi,
With very minor changes to Dockerfile, by to moving to latest Debian release "stretch", thrift works on ARM64 containers.
Can you please review the below changes and suggest if I can raise a PR ? Also, can we plan to officially release the binaries for ARM64 on hub.docker ?
`diff --git a/0.11/Dockerfile b/0.11/Dockerfile index a98ed4f..85fda66 100644 --- a/0.11/Dockerfile +++ b/0.11/Dockerfile @@ -1,4 +1,4 @@ -FROM debian:wheezy +FROM debian:stretch LABEL authors="Adam Hawkins [email protected]"
ENV THRIFT_VERSION 0.11.0
@@ -31,7 +31,11 @@ RUN buildDeps="
&& make install
&& cd /
&& rm -rf /usr/src/thrift \
remove
&& curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz
replace with
&& if [ $(uname -m) = "aarch64" ]; then \
curl -k -sSL "https://storage.googleapis.com/golang/go1.10.1.linux-arm64.tar.gz" -o go.tar.gz ; \
else \
curl -k -sSL "https://storage.googleapis.com/golang/go1.4.linux-amd64.tar.gz" -o go.tar.gz ; \
fi \
`
I just tested Thrift on an AArch64 platform and it appears to work.
Could we please add AArch64 support into the Official Image?
@ahawkins what is the plan for this repo?
All appears to have gone very quiet.
I think it’s best to find a new maintainer. I no longer work with Thrift or have the time to keep up with updates. It’s not fair to the community.
// Adam
On Sep 19, 2019, at 00:45, lag-linaro [email protected] wrote:
@ahawkins what is the plan for this repo?
All appears to have gone very quiet.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.