Andrew Halberstadt

Results 38 comments of Andrew Halberstadt

I'll try crafting some dummy releases on a staging repo to see what events get fired when and report back. We'll want separate scopes for sure, we just may also...

I set up a local server to listen to the webhook and created a pre-release and then "promoted" it. Indeed, it only seends the `released` action and not the `published`...

I think you have the `prerelease` values mixed up, but if you swap them yes that could be one approach. Another approach could be: `action = preleased` -> promote graph...

Thought creating a "draft PR" would not request review... This is not ready for review (but feel free to take a look and comment if you like)

Also if someone could merge https://github.com/taskcluster/taskcluster-rfcs/pull/175 that would be appreciated :)

Note for reviewers, the diff is easier to read with the "Hide whitespace" option checked.

@petemoore @matt-boris @lotas review ping :)

For posterity, I also tested this by hooking up a live Github app to my dev instance and opening PRs on a real repo (both as collaborator and as public)....

Yes, I looked into the checks API awhile back for this very purpose. We can add arbitrary [markdown formatted text](https://docs.github.com/en/rest/reference/checks#output-object). So a log tail + direct link to the log...

WARNING: this is completely untested, expect failures. Putting this up as an example of how to fix bug 1712378.