spacehammer
spacehammer copied to clipboard
agzam
Vendoring fennel?
Just a thought but would it be unreasonable to include fennel source and the other packages we use in the project?
Pros
- Static install location
- Remove luarocks
- More stable, so when fennel updates spacehammer is not broken
Cons
- Bigger repo size
- Fennel wouldn't be available system-wide, but not sure how common that is for people to use outside of spacehammer?
- A script to update those packages would probably be required, but potentially more straight forward than trying to write a package system
If anyone has experience or strong opinions on this, please weigh in!
I have thought about this as well. I think it's a good idea. Fennel is intentionally a single file and they encourage its full source inclusion
.
Bump on this. #176 I'd like to update some of our code, but I don't want to force us to update.
Only concern I can think of is if we have users whose configs use module they have installed that might break on an update. That said, fennel is pretty good at maintaining backwards compatibility.