django-markdown-editor icon indicating copy to clipboard operation
django-markdown-editor copied to clipboard

Published 20 hours ago • verified publisher icon agusmakmun

Dark mode woks not as expected

Open AstRonin opened this issue 1 year ago • 2 comments

Dark mode woks not as expected

Details

  • OS (Operating System) version: Mac (13.3.1 (a))
  • Browser and browser version: Chrome (Version 113.0.5672.63 (Official Build) (arm64))
  • Django version: Django = "^4.1.7"
  • Martor version & theme: martor = "^1.6.20" (bootstrap)

Steps to reproduce

  • Set mode to Dark in System Settings

image

Could we also remove @media (prefers-color-scheme: dark) and make depends on Django mode, not a System?

AstRonin avatar May 11 '23 12:05 AstRonin

I'm seeing this too, but only for body text in Markdown; headings work fine.

grahame avatar Sep 05 '23 07:09 grahame

Seems that title level 1 and 2 need more contrast too image

Sispheor avatar Sep 19 '23 08:09 Sispheor

Hello @AstRonin @grahame @Sispheor, thank you for reporting this issue. Last time we trying to fix this issue: https://github.com/agusmakmun/django-markdown-editor/commit/f8ad4d326d3816fc5168b47ab2d1f01e90c11593

And the result is: Screenshot 2024-03-29 at 22 14 44

It can be a temporary fixes as for now. Removing @media (prefers-color-scheme: dark) we need to spend sometimes to adjust the css of text.

Kindly to upgrade the martor version:

pip install martor --upgrade

agusmakmun avatar Mar 29 '24 15:03 agusmakmun

Hello,

I want to reopen this issue because the display problem with the editor's preview in Django's dark mode persists. The issue was previously marked as resolved and closed, but the problem seems to remain. I suspect there might be an issue with the martor-bootstrap.css, specifically with div.martor-preview, which may not be fully compatible with dark mode, but I am not entirely sure.

Here are the details of my setup:

  • OS version: Windows 10 Pro
  • Browser and version: Chrome 124.0.6367.91 (Official Build)
  • Django version: 4.2.11
  • Martor version: 1.6.44
  • Markdown version: 3.1.1

I have attached screenshots showing the editor, the preview, and the selected preview when using dark mode, which highlight the issue. martor_editor martor_preview1 martor_preview2

Your assistance in resolving this would be greatly appreciated.

Thank you.

wkt84 avatar Apr 30 '24 02:04 wkt84