create-react-app-ssr-pwa icon indicating copy to clipboard operation
create-react-app-ssr-pwa copied to clipboard
verified publisher icon agungsb

Why registerServiceWorker has disabled?

Open rizalibnu opened this issue 8 years ago • 3 comments

I look at src/index.js you disabled serviceworker.

// registerServiceWorker();

I think if you disable it pwa can't work.

rizalibnu avatar Jan 21 '18 06:01 rizalibnu

Hi @rizalibnu ,

Thanks for pointing that out. Actually, I disabled it due to development purpose. But I did forget to uncomment it. I'm gonna do it pretty soon.

Cheers 😁

agungsb avatar Jan 21 '18 08:01 agungsb

@rizalibnu Please feel free to contribute! 💪

agungsb avatar Jan 21 '18 08:01 agungsb

@agungsb i have clone this repo to my local and follow your instructions on README.md, i think data from redux not rendered in SSR. only html from JSX tag that rendered in SSR. Is it not yet ready for redux ?

the image below is screenshot from this page : http://localhost:3001/second screenshot at jan 22 11-56-05

Sure, i'll try to contribute. Let me know if you have any roadmap.

rizalibnu avatar Jan 22 '18 05:01 rizalibnu