pgagroal icon indicating copy to clipboard operation
pgagroal copied to clipboard

Time based configuration generalization

Open aryanA101a opened this issue 10 months ago • 5 comments

@Userfrom1995

I have identified metrics_cache_max_age, blocking_timeout, rotate_frontend_password_timeout, max_connection_age, background_interval, authentication_timout, idle_timeout and log_rotation_age for them to use as_seconds to parse time and generalize their documentation.

aryanA101a avatar Mar 21 '25 05:03 aryanA101a

@aryanA101a just look at my last PR https://github.com/agroal/pgagroal/pull/519 the only changes i have done related to this issue is removed as_logging_rotation_age() function to use as_seconds directly and also updated the documentation for metrics_cache_max_age and log_rotation_age .

Userfrom1995 avatar Mar 21 '25 06:03 Userfrom1995

@jesperpedersen Should I go ahead with the above identified config params?

aryanA101a avatar Mar 21 '25 15:03 aryanA101a

@aryanA101a Yes, go ahead

jesperpedersen avatar Mar 22 '25 13:03 jesperpedersen

@jesperpedersen as_seconds(...) expect unsigned int* as second arg and most of the config params I am migrating from as_int to as_seconds are int.

I believe these time config params should be unsigned. So do I proceed on changing them from int to unsigned int?

aryanA101a avatar Mar 23 '25 14:03 aryanA101a

@aryanA101a Yes, you can do that

jesperpedersen avatar Mar 23 '25 14:03 jesperpedersen