check_run icon indicating copy to clipboard operation
check_run copied to clipboard

Creation of credit note on setup : bench execute 'check_run.tests.setup.before_test'

Open viralkansodiya opened this issue 10 months ago • 8 comments

viralkansodiya avatar Apr 13 '24 08:04 viralkansodiya

@agritheory 1 --> Credit Note Creation in setup.py 2 --> remove >0 condition to take all return entry in check run

viralkansodiya avatar Apr 13 '24 08:04 viralkansodiya

@agritheory

Hi Tyler,

I have added a code in [setup.py](https://github.com/agritheory/check_run/blob/40389d85d3cf71da740a8d8056f25a93d3eaf077/check_run/tests/setup.py#L889) to create a credit note against a sales invoice.

After executing bench execute 'check_run.tests.setup.before_test' , system has generating one credit note

here, I am getting 0.01 USD remain in outstanding please review below image

Main Invoice (Overdue)

main invoice

Return Invoice

return

When a return or credit note is created from the UI, it works perfectly. Can you suggest how to handle this conflict in test cases?

Thanks viral kansodiya

viralkansodiya avatar Apr 15 '24 10:04 viralkansodiya

Force the precision based on the the field level precision, like this

agritheory avatar Apr 15 '24 11:04 agritheory

@agritheory why every invoices has outstanding amount is same as tax amount, it should be the tax_amount + net_total

this happen after run bench execute 'check_run.tests.setup.before_test'

erroerin

viralkansodiya avatar Apr 15 '24 14:04 viralkansodiya

@viralkansodiya No, the only amount that is payable is what is due to the Tax Authority - in the example I think it's 6.25% of the grand total of $100.00. The $100 is a receivable to the company.

agritheory avatar Apr 15 '24 14:04 agritheory

@agritheory you can review this PR and Merge

viralkansodiya avatar Apr 29 '24 10:04 viralkansodiya

@viralkansodiya This should be based on version 15, the changes to the PDF dependencies are not compatible.

agritheory avatar Apr 29 '24 11:04 agritheory

compatible

fixed

viralkansodiya avatar Apr 29 '24 12:04 viralkansodiya

@agritheory should I raise this PR for version 15? or against tax_payable branch is okay

viralkansodiya avatar Apr 30 '24 07:04 viralkansodiya