[app] scan items in stock reconciliation form
Open
lauty95
opened this issue 1 year ago
•
7 comments
Stock Reconciliation Handling Scanning
Demo
https://github.com/user-attachments/assets/8dfc1387-504f-49c4-b676-0aff5bac7311
Coverage Report File Stmts Miss Cover Missing __init__.py 1 0 100% beam barcodes.py 80 34 57% 20 , 29 , 31 , 33 , 36 , 47–48 , 50–51 , 56–59 , 62–63 , 69 , 79 , 87 , 94 , 97–98 , 104–105 , 111 , 117 , 123 , 129 , 136 , 139–142 , 144–145 handling_unit.py 81 37 54% 26 , 32 , 64–66 , 84 , 95–96 , 102–103 , 105–106 , 108–109 , 111–112 , 114 , 116–119 , 121–123 , 125 , 127 , 129–130 , 135 , 137 , 141 , 143–144 , 147 , 149–150 , 158 printing.py 82 64 21% 18–19 , 32–43 , 45–48 , 57–61 , 65–66 , 68–69 , 78–82 , 85–86 , 92–94 , 101–102 , 104–106 , 108–109 , 111 , 116 , 118–119 , 134–139 , 141–150 beam/demand demand.py 338 94 72% 51 , 66 , 123 , 209 , 243 , 290 , 293 , 425–426 , 428–429 , 432–433 , 435 , 439–444 , 446 , 448–449 , 452 , 457 , 459–464 , 466 , 468 , 471 , 474 , 479 , 483–485 , 490–491 , 493 , 495–497 , 499 , 505 , 507–510 , 512–515 , 517 , 519 , 522–523 , 525–526 , 529 , 543 , 560–561 , 563–565 , 621 , 625 , 662 , 667 , 674 , 695–696 , 707 , 713–729 , 853 receiving.py 125 17 86% 79 , 131 , 173 , 214 , 244 , 249–260 sqlite.py 59 1 98% 40 utils.py 59 7 88% 56 , 67 , 72–75 , 83 beam/doctype/beam_mobile_route beam_mobile_route.py 3 0 100% beam/doctype/beam_settings beam_settings.py 28 17 39% 35–37 , 40–41 , 43 , 50 , 55–58 , 66–68 , 72–74 beam/doctype/handling_unit __init__.py 9 3 66% 12–14 handling_unit.py 15 0 100% beam/doctype/warehouse_types warehouse_types.py 3 0 100% beam/overrides sales_order.py 10 6 40% 11–16 stock_entry.py 67 17 74% 61–62 , 67–74 , 80–81 , 97 , 112 , 129 , 132–133 work_order.py 10 2 80% 14 , 16 beam/report/demand_map demand_map.py 35 35 0% 4–5 , 7–8 , 11–12 , 15–16 , 103–111 , 127 , 129–143 , 146–147 beam/report/handling_unit_traceability handling_unit_traceability.py 44 44 0% 4–6 , 9–11 , 30–32 , 34–35 , 37–38 , 41–42 , 45–46 , 48–49 , 51–52 , 54–55 , 57 , 63–65 , 67–69 , 71 , 74–77 , 79–81 , 83–86 , 89–90 beam/scan __init__.py 136 25 81% 21 , 25 , 31 , 39 , 90 , 93–94 , 118–119 , 129 , 131–132 , 136 , 140–141 , 144 , 155–156 , 160 , 181 , 185 , 214 , 216 , 234 , 237 config.py 28 28 0% 4 , 6 , 9–17 , 19–21 , 23–26 , 28–30 , 32–35 , 38–39 , 41 user_login.py 31 31 0% 1–3 , 5 , 8–10 , 14–16 , 18–19 , 21–22 , 24–26 , 28–30 , 32–35 , 37–42 , 44 www/beam __init__.py 14 14 0% 4–7 , 10–19 index.py 7 7 0% 4 , 6 , 9–13 TOTAL 1265 483 61%
@lauty95 Questions about your demo: It looks like scanning at item clears the table, after you've scanned the WH. I don't think that's right, it should add_or_increment instead. Have you tested this with a handling unit?
@agritheory
1 - Yes! It clears the table. I'll update it.
2 - Mmm I haven't tested this with a handling unit. I'll check it out
@agritheory
Demo of changes:
https://github.com/user-attachments/assets/4d957cc0-3143-41b9-925d-580ab7786c30
It would be great if you could test it.
One thing to note: When you scan an HU, it triggers add_or_associate action, which doesn't increment qty , but if you scan a WH that contains that item, it does increment the qty.
@Alchez I'm not using cur_frm.set_value because that method calls functions from stock_reconciliation.js that reset the table.
@Alchez I'm not using cur_frm.set_value because that method calls functions from stock_reconciliation.js that reset the table.
Oh that's weird. In that case, do add a comment around that code that specifies this, in case we need to figure out why it's happening in a non-standard way.
I am experiencing #268 on this branch while attempting to review it.
@agritheory @lauty95 I'm unable to replicate #268 on this branch, but I did see that error on #264. But otherwise, this PR should be good to proceed.