Demand - Proof of Concept

[agritheory]

This feature aligns in part with cases 2 and 3 of this comment of #15. The ideas here need to be refined in order to better understand how it should be used, which is why I'm starting a pull request. As a feature, I think it is likely a prerequisite for performant mobile views, which is why I was developing it in the context of this app, but as a feature, it more strongly aligns with Inventory Tools. We may want to finish the work there and then import it here as a dependency.

The purpose of this feature is to be able to quickly determine if a Work Order or Delivery Note can be started, based on material availability in the required location(s).

I tried several iterations of trying to organize this data in Redis before ultimately giving up - Redis' capabilities for storing structured data is limited and the inability to search by value means that filtering is only possible with the construction a several hash maps, which serve as unsynchronized indexes to other hash maps containing serialized data. It just felt like the wrong tool.

Refactoring to sqllite meant that I could preserve the tabular nature of the data, add indexes and use an ultimately more familiar approach that is still essentially in-memory. Reads from sqllite are notoriously fast and the write operations should be trivial. We may have to implement a write lock or ACID files approach to make sure the file isn't corrupted in a case where it would be manipulated by more than one user.

---

To be considered feature complete, I think the following has to be added:

• [x] Add nuance to the warehouse(s) signaling demand. This should be configurable and based on a multiselect of warehouse type and parent(s) so as to exclude quality/ quarantine warehouses, subcontractor warehouses and/or third-party warehousing solutions. #107
• [x] Test suite should integrate this (leveraging pytest-order) such that the demand result is re-examined after each stock transaction. This also likely means doing a complete manufacturing cycle in the test suite so that we can track manufactured goods all the way to Delivery Note. #108
• [ ] Create endpoints with filters for company, item_code, warehouse, workstation and assigned so that this can integrate with #21
• [x] I've only implemented the bare minimum of updates to the demand table and have not accounted for any logic on how rows should be removed when demand is satisfied. #108
• [ ] This feature should be defeatable in a settings document, probably per-company
• [x] To avoid file corruption concerns, some ACID compliant write wrapper should be added #109
• [ ] #110
• [ ] #111
• [ ] It would be good to add a "planned availability" feature, subject to design

[agritheory]

@Alchez Can you re-implement the demand action map you made inside of build_demand_map? Using the Demand Map report, you can see that transfers and updates aren't implemented.

The tests are currently passing for me locally, but that's because they're not really testing this enough - the results aren't correct.

[Alchez]

@Alchez Can you re-implement the demand action map you made inside of build_demand_map? Using the Demand Map report, you can see that transfers and updates aren't implemented.

The tests are currently passing for me locally, but that's because they're not really testing this enough - the results aren't correct.

@agritheory, I've created #145 since I wasn't sure about the implementation of the demand maps. We can discuss the map-specific changes there.

[github-actions[bot]]

Coverage Report

File	Stmts	Miss	Cover	Missing
__init__.py	1	0	100%
customize.py	24	24	0%	4–5, 7, 10–19, 24–32, 44–45
hooks.py	16	0	100%
install.py	32	32	0%	4, 6–7, 9–11, 14–26, 29–30, 33, 36–37, 39–40, 42, 44–45, 47, 51–52
beam
__init__.py	0	0	100%
barcodes.py	31	19	38%	17–19, 27–29, 31–33, 37, 43–44, 46–47, 52–54, 58–59
boot.py	3	3	0%	4, 7–8
handling_unit.py	81	38	53%	25, 28, 31, 63–65, 83, 94–95, 101–102, 104–105, 107–108, 110–111, 113, 115–118, 120–122, 124, 126, 128–129, 134, 136, 140, 142–143, 146, 148–149, 157
printing.py	61	61	0%	4–6, 8, 11–12, 15–16, 18–21, 24–25, 34–45, 47–54, 58–59, 61–62, 71–75, 78–79, 85–87, 90–91, 94–95, 97–99, 101–102, 104, 109, 111–112
beam/demand
demand.py	301	73	75%	20, 22–23, 26–37, 45, 60, 69, 82, 102, 133, 151, 164, 196–197, 199–200, 204, 206–208, 230, 249–252, 256–259, 263–264, 268–269, 271–273, 276–278, 422–423, 436–438, 441, 443, 445–447, 449, 496, 513–514, 516–518, 568, 572, 612, 619, 650, 654
sqlite.py	43	0	100%
utils.py	42	1	97%	47
beam/doctype
__init__.py	0	0	100%
beam/doctype/beam_settings
__init__.py	0	0	100%
beam_settings.py	10	4	60%	14–17
test_beam_settings.py	3	0	100%
beam/doctype/handling_unit
__init__.py	9	3	66%	12–14
handling_unit.py	14	0	100%
test_handling_unit.py	3	0	100%
beam/doctype/warehouse_types
__init__.py	0	0	100%
warehouse_types.py	3	0	100%
beam/overrides
stock_entry.py	64	16	75%	61–62, 67–74, 80–81, 97, 125, 128–129
work_order.py	10	2	80%	14, 16
beam/print_format
__init__.py	0	0	100%
beam/print_format/handling_unit_label
__init__.py	0	0	100%
beam/print_format/item_barcode
__init__.py	0	0	100%
beam/report
__init__.py	0	0	100%
beam/report/demand_map
__init__.py	0	0	100%
demand_map.py	34	34	0%	4–5, 7–8, 11–12, 15–16, 103–110, 126, 128–142, 145–146
beam/report/handling_unit_traceability
__init__.py	0	0	100%
handling_unit_traceability.py	44	44	0%	4–6, 9–11, 30–32, 34–35, 37–38, 41–42, 45–46, 48–49, 51–52, 54–55, 57, 63–65, 67–69, 71, 74–77, 79–81, 83–86, 89–90
beam/scan
__init__.py	124	19	84%	20, 24–25, 30, 38, 70, 117–118, 128, 130–131, 135, 139–140, 143, 173, 202, 204, 222
config.py	26	26	0%	4, 6, 9–17, 19–21, 23–26, 28–30, 32–35, 37
tests
conftest.py	26	0	100%
fixtures.py	6	0	100%
test_demand.py	244	36	85%	260–263, 272–273, 275–276, 278–279, 281–282, 305–309, 311–314, 316–318, 321–322, 324–328, 340–344
test_handling_unit.py	365	59	83%	18–19, 21–22, 482, 502, 543, 553, 580, 583–584, 587–596, 603–606, 615–617, 619–620, 622–624, 632, 639, 641–647, 649, 659–662, 671–674, 676–678, 686, 693–695, 697
test_hooks_override.py	40	0	100%
test_scan.py	24	0	100%
www
__init__.py	0	0	100%
demand.py	6	6	0%	4, 6, 9–12
TOTAL	1690	500	70%

[agritheory]

Merging features as-is into mobile_v15, but leaving this PR open for completeness