elm-bridge Support GHC 9.8

Jan 21 '24 22:01 ilyakooo0

Thanks! I see there is a tuple fix, but does it work with previous versions of GHC?

Jan 24 '24 06:01 bartavelle

No, it doesn't. Tuples will be broken.

Jan 24 '24 08:01 ilyakooo0

Then it would be helpful to fence that in CPP blocks. Would you mind doing that?

Jan 24 '24 10:01 bartavelle

I just ran into this issue as well, would be great if this pull-request could get accepted.

Jul 01 '24 12:07 runebak

This PR only works on the latest GHC and breaks with other versions, it needs some work before it can be accepted :(

Jul 02 '24 05:07 bartavelle

I am currently time constrained and don't know when I will have time to work on this. Feel free to fork this PR if you need this done urgently.

Jul 02 '24 07:07 ilyakooo0

I don't know how to update this pull-request, but I forked the repo of the pull-request and made the new pull-request there. I just doubled the check for the two types of tuples for the different version of ghc. Found that simpler than any CPP-checks. But let me know if you think otherwise.

Jul 03 '24 06:07 runebak

Where is the new code?

Jul 05 '24 05:07 bartavelle

@runebak you probably want to create a second PR. I will close this one once you create yours.

Jul 05 '24 07:07 ilyakooo0

I made the pull request on the forked repo, now I made a new one here https://github.com/agrafix/elm-bridge/pull/62 instead Sorry, I'm new at pull requesting on github!

Jul 05 '24 09:07 runebak