Albert Graef
Albert Graef
Hold the horses. In purr-data, the test-crashd.pd from #63 actually crashes when closing the patch: ~~~ free(): invalid pointer Pd: signal 6 ~~~ This doesn't happen in vanilla, so I...
The patch in your video looks different from the one you posted in #63. Can you please provide it? Does it use any 3rd party external?
Well, test-crashd.pd also crashes in purr-data without your changes, so there's probably something wrong in purr-data's clone. But your most recent change, moving the deallocation to pdlua_object_free, looks reasonable anyway.
Thanks for the updated test and the video, that clarifies things. However, try as I might, I can't reproduce the crash that you described with Pd 0.55-1 running stock pd-lua...
Your new example also seems to work fine for me in purr-data with pd-lua 0.12.22. (Apart from crashing purr-data when I close the patch, which is obviously a separate issue...
> there you go: Thanks, I can reproduce the crash now. > could you give the version in https://github.com/ben-wes/pd-lua/tree/fix/stablesignals_simple a try? That branch is broken for me, in both vanilla...
> I think that we're leaking sig_info when the object is deleted. But other than that, I think this good! I don't think we do, have a look at [pdlua.c:1934](https://github.com/agraef/pd-lua/pull/63/files#diff-be05f819a0338ff6475de5edabb88815ee6956c1944dd154823801493d4b4539R1934-R1939).
I also found and fixed the purr-data clone issue (which, as I suspected, was unrelated). Will do some more testing of this PR with the other examples tonight if I...
> It works inside plugdata too. I've tested with AddressSanitizer enabled, no issues :) Good to know. Thanks for testing!
> i made one more force push on the other branch which is just this commit ahead of the one we're discussing here: https://github.com/agraef/pd-lua/commit/cbe4d87928af48bebe4ee279ff5c790ca1105252 But I already tested this and...