mu4e-maildirs-extension icon indicating copy to clipboard operation
mu4e-maildirs-extension copied to clipboard

Fix searches for maildirs with spaces in their names

Open mhcerri opened this issue 8 years ago • 6 comments

Currently, the count for any maildirs with spaces shows as 0/0. Quote the maildir name to support spaces.

mhcerri avatar Apr 25 '18 18:04 mhcerri

Looking at the commit diff I believe this won't work if a maildir has a double quote in their name (I know it's unusual but there was issues being reported in the past for this).

IIRC shell-quote-argument func properly escaped the space chars. So I'm not sure what changed lately...

Can you check this before merging, please?

Thank you!

agpchil avatar Apr 28 '18 06:04 agpchil

Hi, @agpchil. You are right.

I created a new maildir with double quotes in its name and the count for it also shows as 0/0 (even with messages in this maildir).

However I wasn't able to jump to that maildir either (using "j"). And even a search like maildir:"/personal/A \"test\"" doesn't return any messages.

mhcerri avatar May 03 '18 03:05 mhcerri

Just merged #48 and then realized it was about the same issue as this. Can you test if it works for you? Thank you!

agpchil avatar Jun 06 '18 08:06 agpchil

@agpchil, I can confirm that mu4e-maildirs-extension-20180606.112 from melpa now has working mail counts on my mailbox with a space.

jackson15j avatar Jun 12 '18 14:06 jackson15j

Thanks for the feedback! @mhcerri & @jackson15j can you post the value of your shell-file-name variable? some people are having issues with this merge (see comments in #48) and this information may be useful for them. Thank you ;)

agpchil avatar Jun 13 '18 08:06 agpchil

Sorry for the delay @agpchil. C-h v shell-file-name in my *mu4e-main* buffer returns "/bin/bash".

jackson15j avatar Jul 03 '18 13:07 jackson15j