dlm icon indicating copy to clipboard operation
dlm copied to clipboard

[Feature] Follow redirects on 405 properly

Open zDyant opened this issue 1 year ago • 4 comments

The range of .is_redirection() does not fit on .is_success(), therefore can't download the file

Url: https://zrn.co/17lite64 Error: `Unrecoverable error while processing https://zrn.co/17lite64 : response status not success - "405 Method Not Allowed"

Not using .is_success() solve this, but might there are a better way

Edit: got confused, said redirection, It's .is_client_error(). Even tough the error is returned, the file can be downloaded

zDyant avatar Jun 29 '24 21:06 zDyant

Thanks for the report :+1:

You are right, it looks like some kind of redirection issue.

agourlay avatar Jul 01 '24 08:07 agourlay

I tried fixing this but it did not look good as redirection on 405 is not a standard thing.

Do you maybe have a clean patch to propose?

agourlay avatar Aug 16 '24 13:08 agourlay

No success either

zDyant avatar Aug 16 '24 14:08 zDyant

I took the liberty to renamed and reclassified the issue now that we have a better understanding.

One of my concern is that it could compromise the code clarity and architecture to implement something a bit exotic in terms of standards.

agourlay avatar Aug 17 '24 08:08 agourlay