Arnaud Gourlay
Arnaud Gourlay
Hi @michaelfeil :wave: The benchmark result you shared indicate a performance regression if I am reading this correctly. I remember we implemented this function without iterators to maximize performance https://github.com/qdrant/qdrant/pull/4023
> This would speed up development cycle. Do you have performance number to back this up?
Thanks for the report! Unfortunately I was not able to reproduce the issue on my end. I wrote a cornichon integration test sending a `HEAD` request followed by a status...
Thanks for taking the time to build a reproducer :+1: However it seems the repository is private, I can't access it.
This looks like an ember-client issue :thinking: If you want to move faster, I'd recommend to write a reproducer using http4s-blaze-client and http4s-ember-client directly and inform the nice http4s folks...
To test a full equivalence, you need to pull the body from the response. I think this is the place that times out. https://github.com/agourlay/cornichon/blob/master/cornichon-core/src/main/scala/com/github/agourlay/cornichon/http/client/Http4sClient.scala#L116-L128
Fixed in https://github.com/agourlay/cornichon/releases/tag/v0.21.4
Dear reviewers, I believe I have addressed all your comments :saluting_face:
Let's keep this PR open to not make cherry picking too difficult in case of patch release. We could stack other PRs on top of it for the next release.
@joein Thanks for handling the merges :clap: