gnome3-emblems icon indicating copy to clipboard operation
gnome3-emblems copied to clipboard

Pull Rquest

Open dr3mro opened this issue 11 years ago • 2 comments

Hello Sir, I have done most of you said but I can't find a way to clear the emblem other than create a button for that please deny the old pull request thank you

dr3mro avatar Jul 27 '13 23:07 dr3mro

Hello @dr3mro!

Thanks for the PR again. I've closed #6 but please, reread my comments again and apply them here.

For the deletion of the emblem, as I told you on twitter perhaps the best option is add an icon just at the beginning of the list with the legend "Clear emblems". If you "select" that icon, then you are clearing all the emblems.

In the other hand, what you could do is that when you click one time in a emblem you select it, when you click back you deselect it. But you will need to take care of the emblems that are already active (will be more complex I think, and I don't even know if it's possible with the API that they provide).

When you fix this PR, please, don't create a new one, just push back to this one. And if you can, fix the commit message explaining the changes (you can do this with git commit --amend.

Thanks & good luck with the changes! I really appreciate them :)

agonzalezro avatar Jul 30 '13 20:07 agonzalezro

Hi again Amr!

Are we going somewhere with this?

Cheers.

agonzalezro avatar Nov 03 '13 17:11 agonzalezro