Agnès Leroy
Agnès Leroy
I don't think it affects tests, @IceTDrinker was saying maybe we have some filter on parameter names but I can't seem to find anything like that. Do you think it's...
@IceTDrinker it's better if you check again tfhe/examples/utilities/generates_test_keys.rs to be sure I'm doing the right thing.
Cc @pdroalves (im off this afternoon, will look at it tomorrow)
@caugonnet I'm closing this PR for now as we don't have a plan for integration yet :slightly_smiling_face:
@andrei-stoian-zama may we close this one?
Hey @lvlanson! The maximum polynomial size supported on GPU is not as high as the one supported on CPU, that's probably why you get this error. This is related to...
*[`Makefile` line 1089 at r1](https://reviewable.io/reviews/zama-ai/tfhe-rs/2236#-OMvaMXnDUm_SNdHpvzf:-OMvaMXnDUm_SNdHpvzg:bmb1d13) ([raw file](https://github.com/zama-ai/tfhe-rs/blob/b171eb3bd8e532bdeb8e8e3b91b8f732fa91ad9d/Makefile#L1089)):* > ```Makefile > > .PHONY: pcc_bench # pcc stands for pre commit checks > pcc_bench: check_fmt clippy_bench > ``` Shouldn't we have a...
The new FFT has been merged, as well as a fix for cast to torus, so I'm closing this one.
I merged a change in the AES GPU bench in the meanwhile where I had to add print bench_id to solve conflicts with main :sweat_smile: