laravel-pint-action icon indicating copy to clipboard operation
laravel-pint-action copied to clipboard

Config doesn't work

Open nemergut opened this issue 2 years ago • 5 comments

Action ignore any changes from pint.json in root directory.

nemergut avatar Jun 20 '23 11:06 nemergut

@nemergut can you illustrate the issue by creating a PR in the https://github.com/aglipanci/laravel-pint-action-demo?

aglipanci avatar Jun 28 '23 08:06 aglipanci

Same issue here pint.json in root directory being ignored. Specifying it via configPath: "pint.json" also doesn't help.

schaeferalex avatar Jul 14 '23 09:07 schaeferalex

@nemergut @schaeferalex It works just fine on my end. You have have a look at the three actions run here: https://github.com/aglipanci/laravel-pint-action-demo/actions

I have edited the pint.json config and the errors are skipped during each run.

If there is a specific case I need you to create a PR with your configs on the demo repository so I can investigate more.

aglipanci avatar Aug 10 '23 13:08 aglipanci

also same issue here, my config looks like this:

      - name: Fix PHP code style issues
        uses: aglipanci/[email protected]
        with:
          preset: laravel
          configPath: "vendor/phonyland/dev-tools/src/pint.json"

and may be i found the cause:

CleanShot 2023-08-23 at 01 20 37

locally i have this composer command, so it is with an equal sign (--config=)

"pint": "vendor/bin/pint --config=vendor/phonyland/dev-tools/src/pint.json",

deligoez avatar Aug 22 '23 22:08 deligoez

@deligoez according to the Laravel docs the equal sign it's not required. Would you mind replicating the same behaviour on the demo repository here?

aglipanci avatar Sep 06 '23 12:09 aglipanci

Closed due to inactivity.

aglipanci avatar Jul 25 '24 15:07 aglipanci