Andrew Gliga

Results 117 comments of Andrew Gliga

@randybascue is this complete or is this different from https://opensource.ebay.com/skin/#education-notice

> I'll update from master, but I think this should be part of at least a minor version since placeholder text will need to be updated in applications that are...

> This is actually nontrivial for teams, since the placeholder needs to switch from being unconditionally `YYYY-MM-DD` to a localized format like `MM/DD/YYYY` for each locale. Alternatively, the placeholder can...

Need to update snapshots in tests. @LuLaValva

LGTM overall codewise I see a couple of bugs. In `localized` we should use `localizedFormat` by default. We should also update the placeholder there. That said, could we have the...

We need to remove all custom outline offsets and then for transparent modifier to add a custom outline offset so it does not focus on the padding/border area but directly...

Probably will add either a token for this, or an `image-disabled` class in util.

Can you provide a screenshot for this? This is actually an invalid issue since you can pass `disabled` to icon-btn as well and disable it. For ebayui we need to...