Anton Gilgur

Results 998 comments of Anton Gilgur

Looks like this is a duplicate of #120 which partially duplicates #115

> Not really related to this PR: It would be nice if the benchmark results were a displayed on PRs as a comment so reviewers can more easily review performance...

We do have that problem, but afaik, most tests run within reasonable bounds and we rarely increase the timeouts, usually only due to adding things to the tests or CI...

> I don't know if https://github.com/argoproj/ is "part of the CNCF’s GitHub Enterprise account" Not currently. Crenshaw (CD Lead) actually opened a Service Desk ticket to get access to them...

I think this effectively duplicates #991 if I'm not mistaken. #1338 is perhaps a more generic version of both as well

> 4.2.10/2.1.11 fixed in #10022, thanks @olemarkus #10022 should also enable fixing 1.2.6 / 1.1.21: `Ensure that the --kubelet-certificate-authority argument is set as appropriate (Scored)`. It's not set by default...

> A more meaningful default namespace associated with the service account will be displayed instead in this new release. For reference, this is referring to #9008

> is that the controller requires a ClusterRole to read the ClusterWorkflowTemplates > Do you think it would be possible to make the "managed-namespace" deployment not depending on Cluster-scoped CRDs...

To make multi-namespace Workflows properly support the k8s security model, we'd probably need a `ClusterWorkflow` CR. A `Workflow` CR does not suffice as it is namespace-scoped. Although you can certainly...