Anton Gilgur

Results 998 comments of Anton Gilgur

> If the current user wants to cancel the executed workflow, they can only delete it, Workflows can already be "Stopped" or "Terminated" via the API/CLI/UI. I'm not sure how...

I've mentioned doing this before too [on Slack](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1715434066008239?thread_ts=1715272782.976389&cid=C01QW9QSSSK) and probably elsewhere too. I was thinking to validate input params _everywhere_, and not just in the UI. Re-using `expr` expressions would...

As an example for anyone looking to take this on, Argo CD has a tiny [`embed.go` file](https://github.com/argoproj/argo-cd/blob/24c080b5cbea6e3af547868e540caf553920dc73/ui/embed.go#L7) in the `ui/` directory with the new [`go:embed` directive](https://pkg.go.dev/embed)

> Although this means losing runtime prop validation, TypeScript’s static type checking ensures type safety during development, making this a reasonable trade-off. Unfortunately, not all users use TypeScript, so we...

Looks like this is a follow-up to #12082 @tooptoop4 indeed, per that discussion, they do have a `retentionPolicy`

Nice find @devstewart. Your interpretation sounds correct to me, and the spec refers to "Completed" as "Succeeded, Failed, or Errored" in [many places](https://argoproj.github.io/argo-workflows/fields/). This misnomer seems to have been missed...

> It's a fairly small and seemingly confined piece of part of the code base so it seems like an okay first contribution yup, my thoughts exactly! and you already...

Hi @devstewart have you made any progress on this? I'd like to fix this bug, so if you don't have plans to work on it soon, I'll take it on...

> This seems like a breaking change. I remember Intuit or other vendors depend on this. It's also an undocumented, internal environment variable, so shouldn't have been relied on by...

> * as far as I know more pages doesn't cost us anything. it doesn't per se. it's more about which is better UX. Too many pages can be hard...