Anton Gilgur
Anton Gilgur
Superseded by #13261
Per https://github.com/argoproj/argo-workflows/pull/6356#discussion_r1574367137 and https://github.com/argoproj/argo-workflows/issues/10178#issuecomment-2068596407, the solution here is actually not entirely straightforward unfortunately (otherwise, I would have submitted a PR directly). A Workflow without a lock shouldn't be creating resources...
@tetora1053 have you had a chance to follow-up on this?
No worries! I took a while to review while I was out sick too. A message or setting your GH status would be helpful, but no big deal either way....
> is this one ready now for @agilgur5 to take another look at when he gets a chance? (and thank you, Anton!) it is -- past 2 weeks have been...
If there has been no PR in some time (in this case 9+ months), yes it is available. No need to ask.
Does #13246's approach make more sense here?
There are still changes requested here
Yes, that's an option with any stale PR, just make sure to credit the original author (easiest way is to add your changes on top of their commits in your...
> I guess I want to understand " to work well with our versioned website" The `release-3.4` and `release-3.5` branches are visible on the versioned docs site. So if you...