Anton Gilgur

Results 999 comments of Anton Gilgur

The issue hasn't had any recent activity because it's never been responded to....

Wanted to post an update here as I think I've narrowed down the issue(s) a bit in [my latest trial-and-error experiment/investigation](https://github.com/agilgur5/physijs-webpack/issues/6#issuecomment-558876696): 1. I believe that the no files output for...

> If so, what is blocking it? It's never been responded to in over a year > Is there anything you can do to help move it forward? I've debugged...

Another issue with the refactor is that it broke refs. [`forwardRef`](https://react.dev/reference/react/forwardRef) probably needs to be used to match the old behavior. Can see how Argo Workflows uses refs [here](https://github.com/argoproj/argo-workflows/blob/8e26eb42b235aaa6b9f41f759574f9df7295313a/ui/src/app/shared/components/object-editor/object-editor.tsx#L35). CI...

Mmm I think that's a bit easier said than done too since there have been a few versions on top of the hooks change. I also don't think the hooks...

@rehevkor5 thanks for debugging this! I was confused as to why I was getting an error when there's a passing unit test on this -- didn't even think to check...

> Note the part that extracts the public key: `Key: privateKey.Public()` Oh I missed that detail (it requires scrolling to the right also). I've edited your initial sample to clarify...

> I'll have to look into this more why it's accepting that 😕 Oh... the code straight up uses the public key to encrypt: https://github.com/argoproj/argo-workflows/blob/5b7d1472f393d60d884d3809b57bde7d4d7bd538/server/auth/sso/sso.go#L182 That seems to date back...

> Although currently, as you stated, since Argo generates both in a k8s Secret there would be no new exploit route Oh it doesn't generate both, it only generates the...

> Just seems weird to me, that Argo WF issues its' own JWE tokens, instead of validating the SSO tokens from the provider. Just to be 100% explicit, as I...