Anton Gilgur
Anton Gilgur
For context, I am currently a Member (though may become a Reviewer at the next membership meeting). Lead > Approver > Reviewer > Member. You can see the Argo governance...
Gah, this already got a merge conflict with a Dependabot PR #12511. Adding `prioritized-review` label to this and #12487 as a result
Oh, interesting, due to the new `isolatedModules` config, the build is [failing](https://github.com/argoproj/argo-workflows/actions/runs/7516274931/job/20461171832?pr=12516) due to missing `import type`. i.e. this PR actually depends on #12514
Fixed another merge conflict in the `yarn.lock`. Still waiting for #12514 to be merged so that this can be unblocked and merged
Merged `main` since #12514 was merged, but getting a [test failure](https://github.com/argoproj/argo-workflows/actions/runs/7768757176/job/21187052202?pr=12516) in `argo-ui` now 😕 . Interestingly enough, the build passes fine (which I had tested), it's only the tests'...
> I guess I'll kick this back to draft as a result since it is pretty blocked on `argo-ui` -- but uh may want my `argo-ui` PRs to be prioritized...
Guh, this is now [failing to typecheck](https://github.com/argoproj/argo-workflows/actions/runs/9045160674/job/24854615361?pr=12516) due to another dep, this time very transitive: https://github.com/ramda/ramda/issues/3415#issuecomment-1757260119, https://github.com/swagger-api/swagger-js/issues/3176, https://github.com/swagger-api/apidom/issues/3279
Ok had to fix that by pinning `types-ramda` as it requires TS v5 per https://github.com/ramda/ramda/issues/3415#issuecomment-1758719123 and https://github.com/swagger-api/swagger-js/issues/3176#issuecomment-1759429014
> ### Verification > 1. `yarn build` works fine > 2. `make start UI=true` works fine and UI seems to function as expected Re-verified, seems to all be fine
I'm gonna go ahead and merge this since I only made the changes necessary to fix CI since this was last approved. It also fixes a bunch of warnings and...