Adam Gibson comments

Results 176 comments of


                                            Adam Gibson

NDArray flatarray serialization improvements, misc spacing changes

Let me break this one up more.

Improve and expand README documentation for NDArray examples

Try to clean this up and add back some more of the context that was there rather than just overriding something completely. I certainly don't mind better clarifying explanations of...

Request: give meaningful error message when attempting to use on heap buffers when creating data buffers

@sdyura I'm not fixing this. Use Bytebuffer.allocateDirect(..) it works that way for a reason. All nd4j data is off heap.

Request: give meaningful error message when attempting to use on heap buffers when creating data buffers

@sdyura Sorry about that. Let me reword the issue and I'll ensure that's in there.

Module-info in nd4j-api-1.0.0-M2.1.jar exports inexistent package org.nd4j.autodiff.validation.listeners

@slava888 I'll take a look at this after the current snapshot builds. Those were auto generated metadata. What is your concrete suggestion here? Remove the metadata?

Custom DataSetIterator not working with ParallelWrapper

@MintakaB feel free to open a PR. It sounds like a simple fix. You definitely don't have to make the case for consistent behavior. Thanks!