ad-silence
ad-silence copied to clipboard
Add support for Deezer
This pr should extend support for Deezer
android app
link: https://play.google.com/store/apps/details?id=deezer.android.app
closes #11
the following build will add support for Deezer. (Due to location restrictions in app, I can only run it on an android emulator.)
Will test it for a couple days before merging to master.
(rename .zip to .apk, restrictions in github comments) ~ad-silence-test-build-7.zip~ @Cwpute in #10 tested this did not work. Build 10 is just making sure the build has all the changes and a notification fix that is unrelated to Deezer. ad-silence-test-build-10.zip
while testing... bugs have been reported
- did not work on Deezer (different android device other than mine)
so until that is verified and fixed, this will not be merged.
i'm not a developer, just use your app but am also a Deezer user. so for what it's worth if i can test anything (on Android 8), let me know.
@unseenlarks nice!
the following build will add support for Deezer. (Due to location restrictions in app, I can only run it on an android emulator.)
Will test it for a couple days before merging to master.
(rename .zip to .apk, restrictions in github comments) ~ad-silence-test-build-7.zip~ @Cwpute in #10 tested this did not work. Build 10 is just making sure the build has all the changes and a notification fix that is unrelated to Deezer. ad-silence-test-build-10.zip
can you test this build for now?
i've just tried to install it but my phone won't have it (even when allowed to install from unknown/third-party sources as i normally would).
@unseenlarks, it might be because of build version, test with the new build below.
I merged it with upstream & fixed conflicts.
if you have previous versions installed from Playstore
or Fdroid
, uninstall it first before installing this.
(rename .zip to .apk, due to restrictions in github comments) ad-silence-test-build-27.zip
still having the same issue unfortunately. my phone won't install this .apk either.
if you have previous versions installed from
Playstore
orFdroid
, uninstall it first before installing this.(rename .zip to .apk, due to restrictions in github comments) ad-silence-test-build-27.zip
could you try this?
thank you, clearly i should have tried that first. finally installed the above build, but unfortunately ads aren't blocked/detected.
Ad-silence has been granted notification access and is enabled to mute ads. Deezer is enabled under 'select apps', and the Ad-silence notification is always visible on the notification drawer. battery optimisation has been disabled for Ad-silence.
when ads are playing, the Ad-silence notification displays 'listening for ads', same as when actual music is playing, or when Deezer itself is closed.