meta-raspberrypi icon indicating copy to clipboard operation
meta-raspberrypi copied to clipboard

rpi-base: Added missing HiFiBerry

Open kluszon opened this issue 1 year ago • 11 comments

…Pro, DAC+ DSP, DAC+ HD, Digi Pro.

- What I did

Added missing support for HiFiBerry AMP100, AMP3, AMP4 Pro, DAC+ ADC Pro, DAC+ DSP, DAC+ HD, Digi Pro.

- How I did it

Add right lines to rpi-base.inc. Changes were tested and works fine with the branch.

Connected also with issue #1168

kluszon avatar Feb 19 '24 12:02 kluszon

Is this a backport from main? If not, why is this kirkstone-specific?

agherzan avatar Feb 19 '24 19:02 agherzan

Is this a backport from main? If not, why is this kirkstone-specific?

It's not a backport, because on main branch you don't have it. I'm working on kirkstone branch and it's a reason. It could be applied to any branch with kernel 5.10 or newer. I didn't test it with older kernels, but some dtbo files can be not available there.

kluszon avatar Feb 20 '24 07:02 kluszon

In that case, I would like for this to be pushed against main first to avoid feature divergence on maintenance branches.

agherzan avatar Feb 20 '24 12:02 agherzan

@agherzan Ok then pull request prepared #1287

kluszon avatar Feb 21 '24 06:02 kluszon

@agherzan Can you do a cherry-pick from 92a9b7a01245507a347c59997a3e5960b0f75ae9 to the Kirkstone branch and close it?

kluszon avatar Mar 05 '24 11:03 kluszon

@kluszon Could you refresh this MR by recreating the branch with the cherry-pick of the commit you've prepared for master? This will kick the gears here and run the CI for kirkstone too.l

agherzan avatar Mar 18 '24 12:03 agherzan

@kluszon Could you refresh this MR by recreating the branch with the cherry-pick of the commit you've prepared for master? This will kick the gears here and run the CI for kirkstone too.l

Done

kluszon avatar Mar 19 '24 06:03 kluszon

@kluszon the builds fail with:

| make[1]: *** No rule to make target 'arch/arm/boot/dts/overlays/hifiberry-amp4pro.dtbo'. Stop.

agherzan avatar Apr 08 '24 17:04 agherzan

@kluszon the builds fail with:

| make[1]: *** No rule to make target 'arch/arm/boot/dts/overlays/hifiberry-amp4pro.dtbo'. Stop.

Your kernel doesn't have the file. I compiled it locally without any problem. What should I do with it?

kluszon avatar Apr 09 '24 10:04 kluszon

I wish I had a kernel :) Joke aside, you're probably building a different version, and not the default kirkstone one. You can see here https://github.com/agherzan/meta-raspberrypi/blob/master/.github/workflows/docker-images/yocto-builder/entrypoint-build.sh how the CI builds the kernel.

agherzan avatar Apr 29 '24 11:04 agherzan

I wish I had a kernel :) Joke aside, you're probably building a different version, and not the default kirkstone one. You can see here https://github.com/agherzan/meta-raspberrypi/blob/master/.github/workflows/docker-images/yocto-builder/entrypoint-build.sh how the CI builds the kernel.

The only I can do is remove the problematic amp4pro.

kluszon avatar May 08 '24 10:05 kluszon