Ardeshir Izadi

Results 61 comments of Ardeshir Izadi

Another API/Event suggestion that could help with this use case, would be a `BEFORE_MOVING` event, which calls a callback before each move/pixel, and the callback can return: - a `true`...

Spotted a problem, just above the footer the color changes a bit. ![image](https://github.com/user-attachments/assets/83be5547-0c34-4f49-ae06-444c2da58756) I'll fix that, and in addition will make the dark theme's background not so black! (no more...

This PR is also blocked by this: https://github.com/ing-bank/lion/pull/2339

Here is the non-test-environment of the same code with the same error. Create a `test.html` file in the root folder of the liom repo, put these in, and do `npx...

This PR: https://github.com/ing-bank/lion/pull/2339 intends to fix this

Intersting @okadurin . I see now what we are trying to test. Yes I may be able to look into this. I'll let you know here if I could come...

I believe I found a better approach @okadurin : https://modern-web.dev/docs/test-runner/cli-and-configuration/#customize-html-environment-per-test-group I can duplicate our test groups (`groups.concat(groups)`), but give each a different `testRunnerHtml`. That works. But right now I'm trying...

@okadurin I've updated my MR and have also updated my original message (https://github.com/ing-bank/lion/pull/2353#issue-2490418176) to list what changes I made. Take another look?

Hi. Saw your message late, but I see all is taken care of now :smiley: Thanks

This PR should fix this: https://github.com/ing-bank/lion/pull/2353 It runs every test with and without this polyfill.