handson-ml3 icon indicating copy to clipboard operation
handson-ml3 copied to clipboard

[IDEA] Remove sharex=False in figure 2-13?

Open oscark22 opened this issue 1 year ago • 1 comments

This isn't a bug, but rather a possible suggested improvement. In figure 2-13 the option sharex=False is used to handle a bug that used to occur in matplotlib.

The argument sharex=False fixes a display bug: without it, the x-axis values and label are not displayed (see: https://github.com/pandas-dev/pandas/issues/10611).

That issue has been resolved. So there's no longer the need to include that argument. This is a possible improvement, the code still works perfectly.

oscark22 avatar May 22 '23 05:05 oscark22