handson-ml2 icon indicating copy to clipboard operation
handson-ml2 copied to clipboard

Chapter 5 - Figure 5.11 correct parameters with French version of the book

Open lebaste77 opened this issue 5 years ago • 3 comments

Hi,

It seems that, in chapter 5, Figure 5.11 the right-side figure does not correspond to the legend : d=2, C=0.01, epsilon=0.1 hyperparams does not generate the figure in the book. It seems that the figure in the book is for d=2, C=0.001, epsilon=0.1

Here is the handbook figure : image

And here is the shape of what is printed in the book (close enough though) : svm_with_polynomial_kernel_plot

Regards,

lebaste77 avatar Oct 27 '20 14:10 lebaste77

Thanks for your feedback. However, I don't see the discrepancy. Indeed, here is what figure 5-11 looks like in my copy of the book:

image

And here is what it looks like in the Jupyter notebook on github:

image

I can't see any difference. And the legend is not hard-coded, it's directly obtained from the svm_poly_reg2 object, so I believe that it's exactly what was used for training.

Did I misunderstand?

ageron avatar Nov 23 '20 07:11 ageron

Hi,

In fact, I am using the French version of the book, and in this one, the figure is different : DSC_7013

Seems like an issue only on the French version then.

Edit : I'm adding that in the volume 2 of the french version (equivalent to chapters 10-19) there are some typos (e.g. bottom note nb 118), some wrong translation (e.g. chapter 4 (i.e. chapter 12) : "noisy data" -> "données bruyantes" -> should be "bruitées" instead ?) and some missing parts of formulas (especially '⊗' in all formulas of chapter 3 (i.e. chapter 11)).

lebaste77 avatar Dec 26 '20 15:12 lebaste77

Great feedback, thanks @lebaste77 , I'll report these issues to the french editor (Dunod). 👍

ageron avatar Mar 19 '21 23:03 ageron