handson-ml icon indicating copy to clipboard operation
handson-ml copied to clipboard

trouble with urllib

Open shivan-s opened this issue 3 years ago • 2 comments

# get the data

import os
import tarfile
import urllib
DOWNLOAD_ROOT = 'https://raw.githubusercontent.com/ageron/handson-ml2/master/'
HOUSING_PATH = os.path.join('datasets', 'housing')
HOUSING_URL = DOWNLOAD_ROOT + 'datasets/housing/housing.tgz'

def fetch_housing_data(housing_url=HOUSING_URL, housing_path=HOUSING_PATH):
    os.makedirs(housing_path, exist_ok=True)
    tgz_path = os.path.join(housing_path, 'housing.tgz')
    urllib.request.urlretrieve(housing_url, tgz_path)
    housing_tgz = tarfile.open(tgz_path)
    housing_tgz.extractall(path=housing_path)
    housing_tgz.close()

Not really an error with the code in this notebook but in the book. If you use urllib.request method and error will be thrown as it cannot recognise this method.

The workaround I used was import urllib.request. But I see from six.moves import urllib is used instead.

I don't know if anyone found this was a problem or was discussed. Just through my two cents in there and hoping it will help.

shivan-s avatar Sep 25 '20 23:09 shivan-s

I am also getting the same error.

akshitgupta29 avatar Oct 05 '20 17:10 akshitgupta29

The code in the book is not running properly

GeoSegun avatar Apr 12 '23 21:04 GeoSegun