Yichun Zhang

Results 937 comments of Yichun Zhang

@siddhesh Thanks for looking at this one. You definitely know about the actual arm hardware usage better than me. We can always enable it for the aarch64 world then. We...

We'd better hurry on this PR, we're about to cut a new release. Hopefully we can have it in the next OpenResty version :)

So with this PR the same x64 openresty binary can work on modern intel chips and amd chips at the same time now?

@siddhesh I see. Thanks for the clarification. I'm really looking forward to binary-level auto-scheduling for different microarchitectures.

@jaderhs Thanks for the patch! Looking good to me. I'll merge it after OpenResty 1.7.4.1 is released :)

@siddhesh I'm fine with that though I think `LJ_OR_EXT` is a better name (shorter and more informative). And yes, `LJ_OR_EXT` should be enabled by default in this repo.

We may also need to adapt the openresty/luajit2-test-suite repo to support both modes similar to the existing LUA52 mode.

Yes, we can go with the `OPENRESTY_EXT` macro (shorter) :)

Ah it seems like I proposed an even better name: `LJ_OR_EXT` :)