Yichun Zhang

Results 937 comments of Yichun Zhang

@bompus It seems that @sitano has not updated his branch according to the comments of my last round of review.

Also, there's conflicts between this branch and master that must be solved before this PR can be merged.

I prefer an nginx output variable for this purpose :) Now there's already an undocumented nginx variable $drizzle_thread_id for outputing the mysql thread id. And we usually use a custom...

I'm fine with the capability to suppress logging the drizzle error codes that the user specify :)

Suppressing logging may not be sufficient for your purpose though. Maybe you'd also want those errors to be discarded in context of keepalive database connections? That is, for those drizzle...

I think we should follow the traditional definition of HTTP status code, just as what Piotr says earlier :) We've already extended it to 410 Gone to mean the mysql...

I do like your second suggestion for the status code mapping ;)

@lizhitao67116961 please do not post Chinese text on all my GitHub issues boards. I'd make GitHub a pure English place for my projects. You can join the openresty (Chinese) mailing...

@ctrochalakis Tagged a `v0.59rc1`. Not ready for a formal release yet.

@bhaisaab Patches welcome! :)