Yichun Zhang

Results 937 comments of Yichun Zhang

@p0pr0ck5 Don't worry about the git history too much. I'll always squash before merging manually. Basically it is recommended to use incremental commits for PR submitters in their own branch....

@p0pr0ck5 Sorry for the delay on my side. This is still in my review queue. Will have another close look as soon as I can manage. Thanks!

@p0pr0ck5 Sorry, too busy with other higher priority stuff. Will look into this when I have a chance. Thanks for your understanding and sorry for the delay on my side.

@alubbe To answer your questions: 1. Static C functions cannot be reused outside that compilation unit. 2. No. Those C functions are not meant to be used by other C...

@ghedo @lziest Do you mind reviewing this PR for me? Many thanks!

@kyriosli As the author of the lua-resty-mysql, I have no idea. I usually do not maintain pre-built packages for specific Linux distributions (I welcome 3rd-party contributors though) and this library...

@Seayea I'm not sure if it is a good thing to have in this library. The whole point of this library is strict non-buffered processing of big upload data. If...

@Seayea I'll hold this for a little while until more users ask for it :) Thank you for the contribution!

@antonheryanto Yes, I agree we need a central place for 3rd-party lua-resty-\* libraries :)

@pearzl Mind to create a pull request so that it's easier for us to see and comment?