Yichun Zhang
Yichun Zhang
it did not address the problem i pointed out earlier :) that is, it requires unnecessary epoll_ctl syscalls when ET is used. better make it stateful rather than stateless.
Regarding your offline comments, this is not a premature optimization because system calls are almost always expensive, not to mention the frequency of the wait() calls in reality. Besides, we...
BTW, I'm against merging quick hacks just to make certain things possible because we have to eventually do it right and we'll almost always pay a bigger price when fixing...
Having said that, I'd love to see this pull request evolves (here or somewhere else) to a state where it is good to merge.
> Could you define what that entails? Pass my review :)
@daurnimator Instead of making it a stateless function, I suggest you turn it into something stateful, like the standard Lua io module's file objects. We need at least some kind...
@daurnimator In addition, we may want to make room for the support of waiting on multiple fds at the same time.
@daurnimator Also, please strictly follow the nginx coding style in your patch. For example, 2 blank lines are used to separate function definitions.
Also, among other things, please add corresponding unit tests to the test suite (but I'm afraid the current API deserves a redesign, so better get the API straight first).
@daurnimator Though I admit this PR's goal is meaningful this PR still requires quite some treatment before it can be merged.