Port alias refactor

[agentrickard]

Refactors #487 for testing.

https://www.drupal.org/project/domain/issues/3087449

[hanoii]

Hi, I wonder if you have any feedback into merging this?

[agentrickard]

Tests are failing here and always were. I'll try merging in 8.x-1.x to see, but I suspect they are still going to fail.

Fortunately, we were able to fix d.o. testing, so you can try rolling another patch on the original issue.

https://www.drupal.org/project/domain/issues/3087449

[agentrickard]

@hanoli In case you can't see the Travis results, this test needs to be fixed:

1) Drupal\Tests\domain_alias\Functional\DomainAliasSortTest::testAliasSort
Pattern matched as expected for example.com
Failed asserting that an array is empty.
/home/travis/build/agentrickard/domain/domain_alias/tests/src/Functional/DomainAliasSortTest.php:21

[agentrickard]

That test expects the alias pattern list to come back in a specific order.

There are also numerous coding style violations in this patch.

[agentrickard]

Oddly, this test passes locally and on drupal.org -- https://www.drupal.org/project/domain/issues/3087449#comment-13717294

I wonder why it's failing here.